Adds Rate Limiter to resource_victorops_routing_key.go #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Rate Limiter To Routing Key
|
LGTM but I fear this provider is no longer supported if this has been here for half a year. |
|
@kevalds51 is there any reason this can't get merged and built? |
|
@ehharris Do we plan to merge this or did you encounter something during testing earlier? |
|
@kevalds51 @vertex Sorry folks! I lost access to this repo for a bit and didn't see these messages. I didn't run into any issues testing, this can be merged if it looks good to everyone else. The customer that I had made this for ended up just compiling it off this MR and I haven't heard that they've had any issues with it in the past year or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a rate limiter to resource_victorops_routing_key.go to adhere to 2 requests per second as per the API docs.
Builds off of #19 and partially fixes #18